You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, only a build runs on creation of a PR and no image of the controller is published for testing purposes. No reason to be merging into main before an image of the controller is tested in dev.
Proposal
On PR (pre-merge), run both build + publish steps of the github action workflow. Modify the publish to target the dev ACR instance. Use that for testing, results of testing should be included in the pr as part of review.
A step further
Might be possible to auto-create a PR in aaw-argocd-manifests and statcan/charts to update the chart version and controller image sha.
The text was updated successfully, but these errors were encountered:
Currently, only a
build
runs on creation of a PR and no image of the controller is published for testing purposes. No reason to be merging into main before an image of the controller is tested in dev.Proposal
On PR (pre-merge), run both build + publish steps of the github action workflow. Modify the publish to target the dev ACR instance. Use that for testing, results of testing should be included in the pr as part of review.
A step further
Might be possible to auto-create a PR in aaw-argocd-manifests and statcan/charts to update the chart version and controller image sha.
The text was updated successfully, but these errors were encountered: