Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DevOps): Modify Github Action to build + publish on PR to main #120

Open
Souheil-Yazji opened this issue May 24, 2023 · 0 comments
Open
Assignees

Comments

@Souheil-Yazji
Copy link
Contributor

Currently, only a build runs on creation of a PR and no image of the controller is published for testing purposes. No reason to be merging into main before an image of the controller is tested in dev.

Proposal

On PR (pre-merge), run both build + publish steps of the github action workflow. Modify the publish to target the dev ACR instance. Use that for testing, results of testing should be included in the pr as part of review.

A step further

Might be possible to auto-create a PR in aaw-argocd-manifests and statcan/charts to update the chart version and controller image sha.

@Souheil-Yazji Souheil-Yazji self-assigned this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant