New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contrib component: metacontroller #120

Closed

rohank07 opened this issue Jan 17, 2022 · 5 comments

Assignees

Labels

size/S

Contributor

rohank07 commented Jan 17, 2022 •

edited

Loading

Overview

EPIC: Kubeflow Upgrade Planning

Component	Local Manifests Path	Upstream	Initial Work
metacontroller	apps/metacontroller	`v1.3.1`

The text was updated successfully, but these errors were encountered:

rohank07 added the size/S label

rohank07 mentioned this issue

[EPIC] Kubeflow Upgrade Planning v1.3.1 #110

Closed

rohank07 changed the title ~~Apps component: metacontroller~~ Contrib component: metacontroller

Contributor Author

rohank07 commented Jan 21, 2022 •

edited

Loading

@sylus I think we can close this. meta-controller is brought in by pipelines and there are no custom overrides in v1.2 https://github.com/StatCan/aaw-kubeflow-manifests/blob/master/kustomize/metacontroller/kustomization.yaml

rohank07 self-assigned this

Member

sylus commented Jan 21, 2022

@rohank07 i think we still need to include:

https://github.com/kubeflow/manifests/tree/master/contrib/metacontroller/base ?

Contributor Author

rohank07 commented Jan 21, 2022

There are no differences in the contents of the manifest files in https://github.com/kubeflow/manifests/tree/master/contrib/metacontroller/base and https://github.com/kubeflow/manifests/tree/v1.3.1/apps/pipeline/upstream/third-party/metacontroller/base

Member

sylus commented Jan 21, 2022

Hmm very odd your right and ok then I guess we good!

rohank07 closed this as completed

Contributor Author

rohank07 commented Jan 21, 2022 •

edited

Loading

Closing: Came to conclusion metacontroller is included in pipeline's base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment