Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Component: kubeflow-namespace #112

Closed
sylus opened this issue Jan 17, 2022 · 0 comments · Fixed by #128
Closed

Common Component: kubeflow-namespace #112

sylus opened this issue Jan 17, 2022 · 0 comments · Fixed by #128
Assignees
Labels
size/S ~1 day

Comments

@sylus
Copy link
Member

sylus commented Jan 17, 2022

Overview

EPIC: Kubeflow Upgrade Planning

Component Local Manifests Path Upstream Initial Work
kubeflow-namespace common/kubeflow-namespace v1.3.1

Adjustments

  • Remove the control-plane label from kubeflow namespace

Kubeflow V2 Manifests

The following is the kustomize that was used in Kubeflow V2:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
patches:
- path: namespace_patch.json
  target:
    kind: Namespace
    name: kubeflow
    version: v1
resources:
- ../../.cache/manifests/manifests-1.2-branch/namespaces/base

AAW Dev / Prod Live Manifests

At the moment there is no difference in state then what is overridden above.

Note: While most everything 95% would have been automated, stored as config and is using what is referenced above. I believe a few things could have been done as manual adjustments that we should make sure we are keeping. Largely any manual yaml adjustments would have been documented in high level GitHub issues or tracked in the YAML repository under the AAW group.

Kubeflow V3 Manifests

The following is the P.R. that will be merged into the main branch for Kubeflow V3:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
- github.com/kubeflow/manifests/common/kubeflow-namespace/base?ref=v1.3.1

patches:
- path: namespace_patch.json
  target:
    kind: Namespace
    name: kubeflow
    version: v1

Testing

Usually a good idea to make sure all of the overrides are working is to run the following command and verify all of the yaml output for the component is what you expect and all of the overrides are taken into account.

  • The kubeflow-namespace Namespace is patched correctly (removed label)
task stack:aaw:preview

Note: The command above will render all of the manifests into manifests top level folder with the name aaw.yaml. A trick to keep the yaml output small is under stacks/aaw/kustomization.yaml to only have the component you wish to test referenced.

@sylus sylus added the size/S ~1 day label Jan 17, 2022
@rohank07 rohank07 self-assigned this Jan 17, 2022
@rohank07 rohank07 linked a pull request Jan 18, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S ~1 day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants