Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jupyterlab python package #622

Closed
wants to merge 2 commits into from
Closed

Conversation

bryanpaget
Copy link
Contributor

Add jupyterlab python package.

@bryanpaget bryanpaget added the auto-deploy Trigger manual CI steps for this PR label May 7, 2024
Jose-Matsuda
Jose-Matsuda previously approved these changes May 8, 2024
@Jose-Matsuda
Copy link
Contributor

Just adding context; this issue broke both branches;
related commit to 2.0 branch is: 9b5fcc2

image

@Souheil-Yazji
Copy link
Contributor

I thought this package was in the base images we use? see
https://github.com/jupyter/docker-stacks/blob/main/images/base-notebook/Dockerfile#L42

@bryanpaget
Copy link
Contributor Author

I thought this package was in the base images we use? see https://github.com/jupyter/docker-stacks/blob/main/images/base-notebook/Dockerfile#L42

I know! A new version was released May 06, which is the day our builds broke:

image

Further investigation may be required to truly understand how this broke our builds.

@bryanpaget
Copy link
Contributor Author

bryanpaget commented May 8, 2024

I can confirm this issue has nothing to do with the upstream Docker images as I am able to build:

I am also able to build the refactored JupyterLab image:

@bryanpaget
Copy link
Contributor Author

This is for main and no longer an issue.

@bryanpaget bryanpaget closed this Jun 26, 2024
@bryanpaget bryanpaget deleted the bryan-fix-jupyterlab branch August 9, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-deploy Trigger manual CI steps for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds blocked by JupyterLab Python package error.
3 participants