Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix getNextWorker overflow (backport #53213) #53269

Open
wants to merge 1 commit into
base: branch-3.3
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 27, 2024

Why I'm doing:

The getNextWorker() method uses a global AtomicInteger nextIndexId, which increments by one with each call to getNextWorker(). As a result, it may overflow into a negative value.

java.lang.ArrayIndexOutOfBoundsException: Index -1 out of bounds for length 3
        at com.google.common.collect.RegularImmutableMap$Values.get(RegularImmutableMap.java:384) ~[spark-dpp-1.0.0.jar:?]
        at com.starrocks.qe.scheduler.DefaultWorkerProvider.getNextWorker(DefaultWorkerProvider.java:354) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.scheduler.DefaultWorkerProvider.selectNextWorker(DefaultWorkerProvider.java:141) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.scheduler.assignment.RemoteFragmentAssignmentStrategy.assignGatherFragmentToWorker(RemoteFragmentAssignmentStrategy.java:91) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.scheduler.assignment.RemoteFragmentAssignmentStrategy.assignFragmentToWorker(RemoteFragmentAssignmentStrategy.java:76) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.CoordinatorPreprocessor.computeFragmentInstances(CoordinatorPreprocessor.java:244) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.CoordinatorPreprocessor.prepareExec(CoordinatorPreprocessor.java:200) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.DefaultCoordinator.prepareExec(DefaultCoordinator.java:456) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.DefaultCoordinator.startScheduling(DefaultCoordinator.java:501) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.scheduler.Coordinator.startScheduling(Coordinator.java:105) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.scheduler.Coordinator.exec(Coordinator.java:88) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.StmtExecutor.handleQueryStmt(StmtExecutor.java:1119) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.StmtExecutor.execute(StmtExecutor.java:633) ~[starrocks-fe.jar:?]

What I'm doing:

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

Why I'm doing:

The getNextWorker() method uses a global AtomicInteger nextIndexId, which increments by one with each call to getNextWorker(). As a result, it may overflow into a negative value.

java.lang.ArrayIndexOutOfBoundsException: Index -1 out of bounds for length 3
        at com.google.common.collect.RegularImmutableMap$Values.get(RegularImmutableMap.java:384) ~[spark-dpp-1.0.0.jar:?]
        at com.starrocks.qe.scheduler.DefaultWorkerProvider.getNextWorker(DefaultWorkerProvider.java:354) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.scheduler.DefaultWorkerProvider.selectNextWorker(DefaultWorkerProvider.java:141) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.scheduler.assignment.RemoteFragmentAssignmentStrategy.assignGatherFragmentToWorker(RemoteFragmentAssignmentStrategy.java:91) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.scheduler.assignment.RemoteFragmentAssignmentStrategy.assignFragmentToWorker(RemoteFragmentAssignmentStrategy.java:76) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.CoordinatorPreprocessor.computeFragmentInstances(CoordinatorPreprocessor.java:244) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.CoordinatorPreprocessor.prepareExec(CoordinatorPreprocessor.java:200) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.DefaultCoordinator.prepareExec(DefaultCoordinator.java:456) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.DefaultCoordinator.startScheduling(DefaultCoordinator.java:501) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.scheduler.Coordinator.startScheduling(Coordinator.java:105) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.scheduler.Coordinator.exec(Coordinator.java:88) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.StmtExecutor.handleQueryStmt(StmtExecutor.java:1119) ~[starrocks-fe.jar:?]
        at com.starrocks.qe.StmtExecutor.execute(StmtExecutor.java:633) ~[starrocks-fe.jar:?]

What I'm doing:

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: zihe.liu <[email protected]>
(cherry picked from commit 4e70ef5)
Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant