Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only perform solvePnP once (on the goal we're actually going to use) #35

Open
andrewda opened this issue Feb 1, 2019 · 1 comment
Open

Comments

@andrewda
Copy link
Member

andrewda commented Feb 1, 2019

Currently, solvePnP is run on all goals, regardless of whether or not we're actually going to use those numbers. We're actually using the numbers from solvePnP to determine which goal is the most central when "locking" onto a new goal, but that can easily be replaced by the goals pixel center offset.

All the solvePnP stuff should be moved out into a new function that is run after we determine which goal we specifically want to use, either from the lock id or as the center-most goal.

@andrewda
Copy link
Member Author

andrewda commented Feb 1, 2019

It's actually working insanely fast right now, but this might still be a good QoL improvement.

@andrewda andrewda transferred this issue from SouthEugeneRoboticsTeam/DeepSpace-2019-Vision Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant