Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket.kickOut fails #49

Open
MegaGM opened this issue Jan 31, 2023 · 3 comments · Fixed by #51
Open

socket.kickOut fails #49

MegaGM opened this issue Jan 31, 2023 · 3 comments · Fixed by #51
Assignees
@MegaGM

Comments

@MegaGM
Copy link
Member

MegaGM commented Jan 31, 2023

socket.kickOut() with no arguments provided fails to unsubscribe the socket from channels.

await socket.exchange.invokePublish('foo', 1)
socket.kickOut()
await sleep(300)
await socket.exchange.invokePublish('foo', 2)

Client receives #kickOut but still receives the second message after that.
socketcluster-server v14 and v17 exhibit the same behavior.

Slightly related #29
@MegaGM
Copy link
Member Author

MegaGM commented Jan 31, 2023

I'll make PRs, which also will enable accepting arrays.
socket.kickOut(['foo', 'bar'], 'message')

@MegaGM MegaGM self-assigned this Jan 31, 2023
This was referenced Jan 31, 2023
Merged
Merged
@MegaGM
Copy link
Member Author

MegaGM commented Feb 8, 2023 •
edited
Loading

TODO

@MegaGM
Copy link
Member Author

MegaGM commented Feb 9, 2023

I guess I'll reopen this issue until

@MegaGM MegaGM reopened this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MegaGM MegaGM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix socket.kickOut() v17 MegaGM/socketcluster-server
1 participant
@MegaGM