fix-an-issue-of-thermostat-does-not-support-fan-speed

[pInksenberg]

Check all that apply

Type of Change

• WWST Certification Request
  • If this is your first time contributing code:
    • I have reviewed the README.md file
    • I have reviewed the CODE_OF_CONDUCT.md file
    • I have signed the CLA
  • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• Bug fix
• New feature
• Refactor

Checklist

• I have performed a self-review of my code
• I have commented my code in hard-to-understand areas
• I have verified my changes by testing with a device or have communicated a plan for testing
• I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Problem:
The LengCeoi HAVC Remote were recently tested in ST App, which include Thermostat and Fan device type. However the capabilities in plugin shows incorrectly

Expectation Result:
The capabilities of thermostat, humidity, fan speed, thermostat mode, thermostat fan mode and set temperature show in the ST plugin.

Current Issue:
The plugin show fan mode and fan speed.

Analysis:
Is it found that the edge driver(matter-thermostat) will re-assign a new profile while driver initialize, and go to the Fan logic, the fan logic does not check if the device support thermostat, or humidity, which means it will re-assign the “fan-generic” for driver.

The profile name re-assign logic is changed to check if the fan speed is supported.

Related tickets: https://smartthings.atlassian.net/browse/MTR-866

Summary of Completed Tests

[github-actions]

Duplicate profile check: Passed - no duplicate profiles detected.

[github-actions]

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/Boj0m8J7amMA

[github-actions]

Test Results

   64 files  ±0    402 suites  ±0   0s ⏱️ ±0s
2 000 tests ±0  2 000 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 455 runs  ±0  3 455 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bf54799. ± Comparison against base commit 5f9650e.

[github-actions]

File	Coverage
All files	83%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua	85%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua	42%	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against bf54799