Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove health_check functionality from zigbee-smoke-detector #1805

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

cjswedes
Copy link
Contributor

@cjswedes cjswedes commented Dec 9, 2024

This is done to get some memory and latency performance increases. Tested with the Orvibo gas detector.

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

This is done to get some memory and latency performance increases.
Tested with the Orvibo gas detector.
@cjswedes cjswedes requested review from greens and ctowns December 9, 2024 15:30
Copy link

github-actions bot commented Dec 9, 2024

Channel deleted.

Copy link

github-actions bot commented Dec 9, 2024

Test Results

   64 files    402 suites   0s ⏱️
2 000 tests 2 000 ✅ 0 💤 0 ❌
3 455 runs  3 455 ✅ 0 💤 0 ❌

Results for commit a310a2d.

Copy link

github-actions bot commented Dec 9, 2024

File Coverage
All files 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-smoke-alarm/src/zwave-smoke-co-alarm-v2/fibaro-co-sensor-zw5/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-smoke-alarm/src/preferences.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-smoke-alarm/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-smoke-alarm/src/apiv6_bugfix/init.lua 87%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-smoke-alarm/src/fibaro-smoke-sensor/init.lua 95%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against a310a2d

Copy link
Contributor

@ctowns ctowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjswedes cjswedes merged commit 34a1afe into main Dec 9, 2024
11 checks passed
@cjswedes cjswedes deleted the feature/remove-health-check-smoke-sensor branch December 9, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants