Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds extensions for registration #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

solonovamax
Copy link

@solonovamax solonovamax commented Oct 7, 2024

Adds the following

  • extensions for registering things to a Registry
  • methods for some random builders (including ones that aren't necessarily for use in a registry)
  • Introduces a dedicated silk-fabric module (included in the -all jar), as the fabric api was depended on in several places.

This is split off from #59.

This also includes functions for creating things that are part of a registry

Signed-off-by: solonovamax <[email protected]>
solonovamax added a commit to solonovamax/silk that referenced this pull request Oct 7, 2024
These will be re-added in other PRs (SilkMC#66 and SilkMC#67)

Signed-off-by: solonovamax <[email protected]>
@solonovamax
Copy link
Author

@jakobkmar Given the addition of a silk-fabric module, should some of the other fabric-specific things be moved to it?
such as:

  • any mixins (& anything that depends on them)
  • all the fabric entrypoints
  • anything that initializes things that paper might complain about

@jakobkmar
Copy link
Member

@solonovamax I have to figure out the whole project structure (i.e. what to use, modules or source sets and how to order them - and how everything is published), I'll let you know once that is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants