Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new setLore funciton in style of setCustomName #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flerbuster
Copy link

it feels wrong calling setLore like this

setLore(listOf(literalText(...) { ... }...

@jakobkmar
Copy link
Member

This seems counter intuitive, since this would add multiple lines even without calling newLine().
For example, simpling changing the color would result in a new line (if you do not wrap every line in a dummy text component).

This function should search for \n instead.

@r0yzer
Copy link

r0yzer commented Mar 4, 2024

ich hab rr kein plan was du damit meinst

@flerbuster
Copy link
Author

ich rr auch nicht

@flerbuster

This comment was marked as spam.

@jakobkmar
Copy link
Member

jakobkmar commented Mar 4, 2024

One sibling != one line.

A component is broken down into more parts than just lines, styling, color and interactivity changes also result in more siblings.

@flerbuster
Copy link
Author

flerbuster commented Mar 4, 2024

One sibling != one line.

A component is broken down into more parts than just lines, styling, color and interactivity changes also result in more siblings.

can you not just do a sibling in the sibling of the sibling and achieve the same thing

@jakobkmar
Copy link
Member

can you not just do a sibling in the sibling of the sibling and achieve the same thing

That would be very very unintuitive. It should be newLine() -> a line break will be inserted.

@flerbuster

This comment was marked as off-topic.

@SilkMC SilkMC deleted a comment from flerbuster Mar 4, 2024
@flerbuster
Copy link
Author

i will see what i can do but i think i am not smart genug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants