-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace CMarkup with TinyXML2 #1
Comments
Another option now that I think of it is contacting the developers of CMarkup and seeing if they would allow us to use it as part of this open source project. Could be they go for that and i can add the original code back in. I will try reaching out to them tomorrow and report back. |
Doesn't hurt to ask. I haven't used CMarkup before so I don't know what advantages it has over TinyXML or TinyXML2. |
Back when I wrote it CMarkup was the best XML library out there. No clue now. |
Fars it goes, the t3d side's already bundling https://github.com/GarageGames/Torque3D/tree/development/Engine/lib/tinyxml so yeah, a switch over would cut down on the dependency hunting... |
Well we still want to maintain our own dependencies in this repo separate from T3D/2D, but there might be some benefit to having XML parser compatibility with the engines. But really if the CMarkup guys let us use their product here i'd rather do that because it works fine without any code changes to Torsion. So less chance of bugs to start with. |
Fair enough. Do look forward to seeing where this goes at any rate. |
Any update on this? What version of CMarkup is being used by Torsion? |
No update... I personally don't have time to go integrate TinyXML2.
It was a really old version... 7.1. It was very robust when I used it originally and I doubt anything would be broken by using the newest release. The only issue with it is that it isn't open source. |
What version of MarkupSTL did you use? |
Im working to remove CMarkup , have you got any documentation for it so to ease the transition ? Im trying thinyxml |
The latest CMarkup docs are here... http://www.firstobject.com/dn_markupmethods.htm I don't think the API changed all that much from back then... but it could be a little different. |
tkz ;) |
Ok I'm done with the porting, but I have problems in compiling wxWidgets in VS 2015... It seams that it is outdated version 2.6.3... Can you help me ? Also excuse me for the messy code... I had lot of old code comments around because I want to have the old functions handy to understand the exact meaning. |
Any news about this? And do you have a separate branch now? |
Hello, I put on 2 pull requests now, I have only 24 linker problems to overcome, I need a little help, thanks !! |
You can make visual studio use an older toolset, but still get the features of the updated visual studio 2019. Like load the 2012 toolchain and it should compile just fine, I think that was the visual studio version originally. BTW: Hi everyone I'm StOrM3, I have a huge project planned for T3D, updating the renderers to use DX12 and Vulkan. I'm basically going to attempt to merge wicked engine which is also open source with T3D. Fingers crossed. |
Ah this is an abandoned project. I'm with Godot Engine guys now !! I supported Torque community years ago.. Now with Godot out is meaningless to support this |
did you ever work further on Torsion? |
Torsion used an XML parser/writer library called CMarkup which is not open source:
http://www.firstobject.com/dn_markstlplat.htm
I've omitted that from this code base and we need to replace it with something equivalently simple, easy to use, and open source.
I suggest we use TinyXML2:
https://github.com/leethomason/tinyxml2
This fix is critical to getting Torsion running again.
The text was updated successfully, but these errors were encountered: