Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme block type (definition) completion #627

Open
Tracked by #545
charlespwd opened this issue Nov 28, 2024 · 0 comments · May be fixed by #632
Open
Tracked by #545

Theme block type (definition) completion #627

charlespwd opened this issue Nov 28, 2024 · 0 comments · May be fixed by #632
Assignees
@charlespwd

Comments

@charlespwd
Copy link
Contributor

charlespwd commented Nov 28, 2024 •
edited
Loading

In a theme or section schema, when a user is completing top level "blocks.[].type" values, we should complete all of

  • @theme when it makes sense
  • @app when it makes sense
  • in section files,
    • if no local block exist
      • theme block names
  • in block files
    • theme block names
This was referenced Nov 28, 2024
Open
Merged
charlespwd added a commit that referenced this issue Dec 2, 2024
@charlespwd
Add theme block type completion in {% schema %}
f9fefff 
The `BlockTypeCompletionProvider` offers value completions of the
`blocks.[].type` property inside section and theme block `{% schema %}` tags.

```liquid
{% schema %}
{
  "blocks": [
    { "type": "█" },
  ]
}
{% endschema %}
```

Fixes #627
charlespwd added a commit that referenced this issue Dec 2, 2024
@charlespwd
Add theme block type completion in {% schema %}
13ff1da 
The `BlockTypeCompletionProvider` offers value completions of the
`blocks.[].type` property inside section and theme block `{% schema %}` tags.

```liquid
{% schema %}
{
  "blocks": [
    { "type": "█" },
  ]
}
{% endschema %}
```

Fixes #627
@charlespwd charlespwd linked a pull request Dec 2, 2024 that will close this issue
Open
1 task
charlespwd added a commit that referenced this issue Dec 2, 2024
@charlespwd
Add theme block type completion in {% schema %}
b041721 
The `BlockTypeCompletionProvider` offers value completions of the
`blocks.[].type` property inside section and theme block `{% schema %}` tags.

```liquid
{% schema %}
{
  "blocks": [
    { "type": "█" },
  ]
}
{% endschema %}
```

Fixes #627
@charlespwd charlespwd self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlespwd charlespwd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add theme block type completion in {% schema %} Shopify/theme-tools
1 participant
@charlespwd