Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate preset settings #602

Open
2 of 8 tasks
Tracked by #545
charlespwd opened this issue Nov 18, 2024 · 0 comments
Open
2 of 8 tasks
Tracked by #545

Validate preset settings #602

charlespwd opened this issue Nov 18, 2024 · 0 comments
Assignees
@AribaRajput

Comments

@charlespwd
Copy link
Contributor

charlespwd commented Nov 18, 2024 •
edited by AribaRajput
Loading

Describe the solution you'd like

  • For blocks:
    • The presets.[].settings values should be validated against the settings for that block
    • The presets.[].blocks.[].settings values should be validated against the settings for the theme blocks of the corresponding type
  • For sections
    • the default.settings values should be validated against the settings for that block
    • the default.blocks.[].settings values should be validated against the settings for that block
    • The presets.[].settings values should be validated against the settings for that block
    • The presets.[].blocks.[].settings values should be validated against the settings for the theme blocks of the corresponding type
      • if a local block, validate against the settings of the local block
      • if a theme block, validate against the settings of the theme block

Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AribaRajput AribaRajput

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charlespwd @AribaRajput