Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple ./packages-*/ directories #946

Open
kaelig opened this issue Sep 16, 2019 · 0 comments
Open

Support multiple ./packages-*/ directories #946

kaelig opened this issue Sep 16, 2019 · 0 comments

Comments

@kaelig
Copy link
Contributor

kaelig commented Sep 16, 2019

This line:

ACTUAL_PACKAGE_VERSION=$(node -e "console.log(require('./packages/$PACKAGE_NAME/package.json').version)")

Fails deploys of polaris-icons for packages not in /packages/.

In this deployment:
https://shipit.shopify.io/shopify/polaris-icons/libraries-js/deploys/843212

The version in ./packages-ruby/polaris_icons/package.json isn't being detected correctly:

$ assert-lerna-independent-version-tags
pid: 362510
module.js:550
    throw err;
    ^
Error: Cannot find module './packages/polaris_icons/package.json'
    at Function.Module._resolveFilename (module.js:548:15)
    at Function.Module._load (module.js:475:25)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at [eval]:1:13
    at ContextifyScript.Script.runInThisContext (vm.js:50:33)
    at Object.runInThisContext (vm.js:139:38)
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:653:30)
    at evalScript (bootstrap_node.js:479:27)
polaris_icons is tagged as 0.3.0, but its package.json version is .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant