categories are retrieved based on site_id #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcaramelsyrup
requested changes
Feb 6, 2021
| @@ -12,11 +12,17 @@ def subcategories | |||
| end | |||
|
|
|||
| def index | |||
| categories = Category.order(:name) | |||
| # categories = Category.order(:name) | |||
There was a problem hiding this comment.
Please remove if no longer necessary.
| categories = if params[:site_id] | ||
| Site.find(params[:site_id]).categories | ||
| else | ||
| Site.find(0).categories #sfsg |
There was a problem hiding this comment.
sfsg is not necessarily site_id 0 - a safer way would be using find_by(site_code: 'sfsg').
| else | ||
| Site.find(0).categories #sfsg | ||
| end | ||
|
|
||
| top_level = ActiveRecord::Type::Boolean.new.cast(params[:top_level]) | ||
| categories = categories.where(top_level: top_level) unless top_level.nil? |
There was a problem hiding this comment.
Can we preserve the previous commented-out behavior by ordering by name after filtering by site?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated index code to now show categories based on site_id.