Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure JWT auth token response from OIDC server is validated #33

Open
agrski opened this issue Sep 27, 2021 · 0 comments
Open

Ensure JWT auth token response from OIDC server is validated #33

agrski opened this issue Sep 27, 2021 · 0 comments

Comments

@agrski
Copy link
Contributor

agrski commented Sep 27, 2021

Right now we do not explicitly validate the JWT tokens returned from whatever OIDC provider is in use.
We should confirm that either:

  1. authlib handles this for us, or
  2. We explicitly validate the returned tokens (in particular the id_token, as this is what is used)

I prefer the latter, as the implementation of authlib may change, even if it handles validation now.

Steps required:

  • Download JWK key-set from well-known endpoint
  • Load key-set in authlib as an OAuth key
  • Validate the id_token or the entire response from the token endpoint, as appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant