Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log addition and revision #39

Open
DG12 opened this issue Jul 15, 2019 · 1 comment
Open

log addition and revision #39

DG12 opened this issue Jul 15, 2019 · 1 comment

Comments

@DG12
Copy link

DG12 commented Jul 15, 2019

It would be helpful to have the log include a startup message including the version in Main
something like
LOG.info("Version: 0.2.4 begins with args:"+args+":");

Additionally, since configuration only occurs at startup perhaps using
LOG.info in config/Config.java (instead of .debug) would be helpful and not clutter logs.

For that matter LOG.info of EVERY getProperty in readConfigFromProperties
LOG.info would not only document properties but also assist in diagnosing incorrect/misspelled property names.

Thanks

@Scrin
Copy link
Owner

Scrin commented Jun 17, 2020

I don't really like the idea of logging every property, as the properties can include passwords and I don't like seeing such things in the logs.

On the other hand the misspelled property names is a valid concern as RuuviCollector has stable default values for every property so it can be difficult to spot a misspelled property. Perhaps a feature to print a warning for unknown properties would work in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants