QA: mypy warn_unreachable #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- trailing-whitespace hook - CI chore - global file list
- Required manually disabling on @savefig lines in docs/examples.rst - Update files list to include doc/*.rst in filespre-commit-config.yaml
Includes Ruff autofixes: - 11 × D212 (multi-line-summary-first-line) - 1 × RET506 (superfluous-else-raise) - 1 × RET505 (superfluous-else-return) - 1 × I001 (unsorted-imports) Added `PLR5501` to exclude list to preserve readability of TODO block in convert method
- Applied some fixes to [tool.pytest.ini_options]
Bumps [scitools/workflows](https://github.com/scitools/workflows) from 2024.11.3 to 2024.11.5. - [Release notes](https://github.com/scitools/workflows/releases) - [Commits](SciTools/workflows@2024.11.3...2024.11.5) --- updated-dependencies: - dependency-name: scitools/workflows dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
the `disable_error_code` list. Required an ingore entry in repo-review.
ukmo-ccbunney
force-pushed
the
qa_mypy_warn_unreachable
branch
from
bf0774f to
d4c4297
Compare
|
Messed this up. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Small update to turn comment out the following:
as that check is listed in the
disable_error_codelist for mypy.This also requires the
MY103check adding to theignorelist inrepo-review.This was supposed to go into PR #293 , but it got merged before I could update.