-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2D guess bounds #6097
Comments
Some downstream code that might need to change: iris/lib/iris/mesh/components.py Lines 2896 to 2904 in 5c18504
|
There is a bit of code in ESMValCore for guessing bounds of 2D coordinates here, but I have some doubts about how well that works because the results of area weighted regridding with these guessed bounds do not look so good ESMValGroup/ESMValCore#2405 (comment). |
@bouweandela correct me if I'm misreading, but it looks like this code requires there to be existing DimCoords on the cube to derive from. It looks like what's required here is a way to guess 2D bounds without refering to the 1D bounds. |
If the |
✨ Feature Request
Adopt a method for guessing the bounds of 2D coordinates.
Motivation
The
guess_bounds
method is currently only available for 1D coordinates. There are cases where only the 2D coordinates exist and it is not possible to determine the coordinate system of the 1D coordinates from which they derive. In this case, it would be useful to be able to guess the bounds so that functions wich require such bounds can be used.Additional context
Guessing bounds becomes significantly more complex in 2 dimensions, especially when taking into account spherical geometry. A naive approach whish treats coordinates as if they existed in flat space could be easier to program, but it may lead to unusual behaviour near the pole. There is not (at least to me) an obvious algorithm to use to guess these bounds or an obvious answer as to which is the correct bound to guess. We would have to resolve the following questions:
guess_bounds
be invariant in different rotational frames?Ping @nhsavage
The text was updated successfully, but these errors were encountered: