Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rails 7.1 #31

Open
hlascelles opened this issue Oct 6, 2023 · 4 comments
Open

Support Rails 7.1 #31

hlascelles opened this issue Oct 6, 2023 · 4 comments

Comments

@hlascelles
Copy link

With Rails 7.1 out it would be good to raise this pin on this and related gems.

I had a go at a PR but had rbenv install issues, apologies!

@ronen
Copy link
Member

ronen commented Oct 6, 2023

Hi @hlascelles -- thanks for looking into it. Sadly, it's been many years since I've had the opportunity to use Rails (since 5.1 maybe?) and it seems none of the other formerly-active contributors have been active lately either.

I'd be thrilled if you (or anybody else) would want to pick up the mantle and keep SchemaPlus from drifting farther into the land of abandonware. I'm happy to give whatever help/advice I can dredge out of my memory...

@hlascelles
Copy link
Author

Turns out we were only using it in one place, so easiest for us to just not use it. Let's see if anyone else is in need and we can revisit.

@ribeirojose
Copy link

@ronen I'm happy to get it off the ground, but unfortunately have had a couple issues with the tooling/docs setting up the repos and running tests locally after I've tried. Do you have supplementary docs elsewhere or a video demoing your setup? Also, it looks like every schema lib sits on schema_dev for dev support, but are there any helpers to git clone all of them at once / update gems in each individual gem or have you mostly done that by hand?

@ronen
Copy link
Member

ronen commented Feb 3, 2024

@ribeirojose great that you're willing to try this!

@ronen I'm happy to get it off the ground, but unfortunately have had a couple issues with the tooling/docs setting up the repos and running tests locally after I've tried. Do you have supplementary docs elsewhere or a video demoing your setup?

Sorry, no other supplementary docs. The doc starting at https://github.com/SchemaPlus/schema_dev?tab=readme-ov-file#usage used to be sufficient... possibly the ecosystem has changed so that there are glitches?

If it's not obvious, the commands described there are to be run in one of the other schema lib gems, to help test and update those other gems. The docs don't discuss testing and updating schema_dev itself; but schema_dev does have its own specs, so an ordinary "rake spec" in schema_dev should help verify that it still works the way it should.

Also, it looks like every schema lib sits on schema_dev for dev support, but are there any helpers to git clone all of them at once / update gems in each individual gem or have you mostly done that by hand?

Did them all by hand 🙃

I guess the thinking was that each one would need to be tested and verified independently. Though of course a good tool would help do them in bulk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants