[NUI] Prepare extra space to View to attach objects from external #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbitfor
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
hinohie
as code owners
JoogabYun
approved these changes
Dec 3, 2024
dongsug-song
reviewed
Dec 3, 2024
| @@ -48,6 +48,7 @@ public partial class View : Container, IResourcesProvider | |||
| private LayoutTransition layoutTransition; | |||
| private TransitionOptions transitionOptions = null; | |||
| private ThemeData themeData; | |||
| private Dictionary<Type, object> attached; | |||
There was a problem hiding this comment.
정확히 테스트 해보고 말씀 드리는것은 아닙니다만, 혹시라도 문제가 있을까 해서 문의 드립니다.
attached 되는 view 가 dali binding 된 객체이기 때문에 정상적이면 GC 되면서 attached 가 unreachable 되겠지만, dispose queue 에 머물러 있는 상태면 reference 가 보존되어 attached 된 객체들이 GC 가 안 될 것 같은데요, 혹시 Dispose(bool disposing) 에서 강제로 null 로 만들어서 이 코너케이스를 회피할 수 있을까요?
There was a problem hiding this comment.
Explicit dispose 케이스에 대해서 attached를 null로 날려버리는 코드를 추가했습니다.
다만 말씀하신 dispose queue에 들어가는 케이스는.. 제가 이해한 것이 맞는지 모르겠지만 이 시점은 이미 view가 GC의 대상으로 선정된 상태 (implicit dispose) 인데 이 케이스에서는 managed data에 접근하면 안되는 것으로 알고 있어서 (그 시점에 이미 멤버가 GC 되었을 수 있음) attached를 어떻게 하지는 못할 것 같습니다.
Signed-off-by: Jiyun Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
View provides methods to attach extra data (that is not bindable property) from the outside.
API Changes