Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIAvatar] Newton Json dependency #6257

Open
HJLeee opened this issue Aug 8, 2024 · 4 comments · May be fixed by #6487
Open

[AIAvatar] Newton Json dependency #6257

HJLeee opened this issue Aug 8, 2024 · 4 comments · May be fixed by #6487
Assignees

Comments

@HJLeee
Copy link
Contributor

HJLeee commented Aug 8, 2024

I happen to come across AIAvatar impl and realize that it uses Newton Json as below.

<PackageReference Include="Newtonsoft.Json" Version="11.0.2" />

This could create a version mismatch when app uses other version of newton json.
Also, System.Text.Json is known to be faster and take less memory.
Please fix the potential bug before it is released.

Copy link

github-actions bot commented Oct 7, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@HJLeee
Copy link
Contributor Author

HJLeee commented Oct 15, 2024

It seems @huiyueun is no longer in charge of AIAvatar but @dongsug-song from the log.

@github-actions github-actions bot removed the Stale label Oct 16, 2024
@sung-su
Copy link
Contributor

sung-su commented Nov 28, 2024

@AnglerLee Please take a look.

@AnglerLee
Copy link
Collaborator

@sung-su Hello, I am in the process of refactoring the Tizen.AIAvatar project.
This issue has been removed from the refactoring module and changed to use System.Text.Json instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants