Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[니니] Chapter 2. AWS (VPC & Internet Gateway & EC2) #9

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[니니] Chapter 2. AWS (VPC & Internet Gateway & EC2) #9

merged 2 commits into from
Apr 16, 2024

Conversation

sseongeun
Copy link

@sseongeun sseongeun commented Apr 14, 2024 •
edited
Loading

#️⃣ 연관된 이슈


✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?
  • 적절한 라벨을 설정하였나요?
  • 스터디원들에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?

📌 주안점

@sseongeun sseongeun added the ✨ Chapter02 챕터 2 label Apr 14, 2024
@sseongeun sseongeun requested review from kjmq1234 and wnd01jun April 14, 2024 10:04
@sseongeun sseongeun self-assigned this Apr 14, 2024
kjmq1234
kjmq1234 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@kjmq1234 kjmq1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wnd01jun
wnd01jun approved these changes Apr 16, 2024
View reviewed changes
Copy link

@wnd01jun wnd01jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sseongeun sseongeun merged commit f483c81 into nini/main Apr 16, 2024
@sseongeun sseongeun deleted the nini/#2 branch April 16, 2024 03:17
kjmq1234 added a commit that referenced this pull request Jun 18, 2024
@kjmq1234
Merge pull request #41 from SSUMC-6th/nini/#9
0e3bd2a 
[니니] Chapter 9. API & Swagger & Annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wnd01jun wnd01jun wnd01jun approved these changes

@kjmq1234 kjmq1234 kjmq1234 approved these changes

Assignees

@sseongeun sseongeun

Labels
✨ Chapter02 챕터 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sseongeun @kjmq1234 @wnd01jun