Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests with missing requirements #1032

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Skip tests with missing requirements #1032

wants to merge 8 commits into from

Conversation

jesper-friis
Copy link
Collaborator

Description

Skip tests with missing requirements

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK to skip tests locally due to missing of imports, but not on github. In this way we may risk to remove dependencies and thus stop testing parts of the code without it being picked up on in the CI/CD workflows.

If this is to be accepted, we need to have an additional check after ctest, that check that all skipped tests are in the specified list of tests (e.g. mongodb-test cannot run on github)

@jesper-friis
Copy link
Collaborator Author

It is OK to skip tests locally due to missing of imports, but not on github. In this way we may risk to remove dependencies and thus stop testing parts of the code without it being picked up on in the CI/CD workflows.

If this is to be accepted, we need to have an additional check after ctest, that check that all skipped tests are in the specified list of tests (e.g. mongodb-test cannot run on github)

It can be implemented with importskip() checking an environment variable. If it is set, the skip will not be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants