Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid can't build anymore since com.google.android.gms:play-services-ads(-lite) are not open-source. #48

Closed
lfourquaux opened this issue Apr 14, 2020 · 10 comments · Fixed by #74

Comments

@lfourquaux
Copy link

F-Droid can't build anymore since com.google.android.gms:play-services-ads(-lite) are not open-source.

Originally posted by @licaon-kter in #17 (comment)

The F-Droid version is increasingly outdated, it would be nice to have a fully open source, up to date version of UnicodePad.

@TPS
Copy link

TPS commented Aug 17, 2020

@Ryosuke839 What's needed is a flavor to include only what's acceptable to build for F-droid.

@licaon-kter, @IzzySoft: Any pointers on how to do such would be much appreciated. 🙇🏾‍♂️

@IzzySoft
Copy link

I'm neither dev nor packager – so the only advice I can give is check with other apps which have done that (setting up separate flavors). In our *.yml files you can tell them by using gradle with a specific name, e.g.

gradle:
  - foss

foss and fdroid are quite common with those, so a egrep '^\s*- (fdroid|foss)' *.yml should help identifying them.

@t-8ch
Copy link
Contributor

t-8ch commented Jun 24, 2021

@Ryosuke839 Would you accept a pullrequest for such a build variant?

t-8ch added a commit to t-8ch/UnicodePad that referenced this issue Jun 26, 2021
play: Works exactly as before.
fdroid: does not contain any ads/ad libraries making the app compatible
  with FDroid again.

Both variants share the same application ID so users of both platforms
will get seamless upgrades.

Fixes Ryosuke839#48.
t-8ch added a commit to t-8ch/UnicodePad that referenced this issue Jun 26, 2021
play: Works exactly as before.
fdroid: does not contain any ads/ad libraries making the app compatible
  with FDroid again.

Both variants share the same application ID so users of both platforms
will get seamless upgrades.

Fixes Ryosuke839#48.
@Ryosuke839
Copy link
Owner

@t-8ch Yes! I will definitely accept on this repo once I validate the behavior.

@t-8ch
Copy link
Contributor

t-8ch commented Jun 26, 2021

@Ryosuke839 Thanks!
@TPS Welp, I managed to mess up the PR, it should against the repo of @Ryosuke839 obviously :-)

@TPS
Copy link

TPS commented Jun 26, 2021

@t-8ch You mentioned a problem in your PR, anyway. Probably better to fix there than PR here until it's resolved? Or not: #74

@t-8ch
Copy link
Contributor

t-8ch commented Jun 26, 2021

@TPS it's more of a validation issue. I expect it to actually work, but for some reason the Ads are not shown at all for me, even in the origin version.
If any changes are necessary I can do those in this PR easily.

@TPS
Copy link

TPS commented Jun 26, 2021

@IzzySoft Now that #74 is merged, is anything else needed to have F-Droid start publishing this again?

@t-8ch
Copy link
Contributor

t-8ch commented Jun 26, 2021

I think the timeline would be:

  • Wait for a new release of UnicodePad (I would just for the one containing Unicode 14)
  • Update the fdroid definitions to activate the "fdroid" flavor

@linsui
Copy link

linsui commented Jun 26, 2021

2.9.1 will be published soon. See https://monitor.f-droid.org/builds/running. When the next release available please open an MR the update the build recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants