Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure of React Frontend #182

Open
hassanzhd opened this issue Jan 23, 2021 · 3 comments
Open

Restructure of React Frontend #182

hassanzhd opened this issue Jan 23, 2021 · 3 comments

Comments

@hassanzhd
Copy link
Collaborator

hassanzhd commented Jan 23, 2021

PROBLEM:-

"Too much coupling of conditional rendering and single level component structure makes it harder for effective flow and leads to inconsistencies."

SOLUTION:-

  • Rather than having all routing logic coupled inside App.js, Decoupling should be done by separating pages as two components:
  1. <LoggedInRoute />
  2. <LoggedOutRoute />
  • Flow should first be determined using loggedIn state, and then verified etc. This will make it easier to map first priority validation.
  • This will also make it easier to segregate any unnecessary state and API calls in case of non logged in user.
@hassanzhd
Copy link
Collaborator Author

@Rubix982, suggestion and ideas appreciated

@Rubix982
Copy link
Owner

@hassanzhd to be discussed after the meeting in-depth.

@Rubix982
Copy link
Owner

Rubix982 commented Feb 3, 2021

We need to split this into two teams to make it work effectively between a side that is working on the client-side restructuring pages, and a team that is working on #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants