Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kvrocks Operator Standard mode release plan #13

Open
jiayouxujin opened this issue May 6, 2023 · 4 comments
Open

Kvrocks Operator Standard mode release plan #13

jiayouxujin opened this issue May 6, 2023 · 4 comments
Labels
help wanted Extra attention is needed summer-ospp-related Information, tasks, and plans related to the Summer OSPP 2023.

Comments

@jiayouxujin
Copy link
Collaborator

jiayouxujin commented May 6, 2023

Hi, all members and contributors of RocksLabs.

Below is my release plan for the Kvrocks Operator in standard mode:

  1. Upgrade the version of dependencies: Currently, the version of our dependencies, such as k8s, is v0.19.x. I suggest that we upgrade the version in this release.
  2. Improve testing: Since our project lacks unit tests and available e2e tests, it is essential to enhance the testing.
  3. Integrate native statefulset: The current code utilizes openkruise, but I recommend supporting native sts by default. The decision to introduce a new CRD should be left to the user.
  4. Use deployment for sentinel: The current code employs sts for sentinel, but I suggest using deployment instead. Simultaneously, there are numerous instances in the original code where sentinel and kvrocks client functions are mixed. We can take this opportunity to reasonably separate them for improved testing.
  5. Introduce monitoring
  6. Fix some bugs or enhance some features: Such as rename the crd

Note: These are relatively large features or plans, and they have not yet been broken down into smaller issues. After I improve the basic development process (such as enhancing e2e testing), I will try to break down the tasks for each part. Everyone is welcome to submit issues or pull requests.

@jiayouxujin
Copy link
Collaborator Author

jiayouxujin commented May 6, 2023

cc @git-hulk @ColinChamber

@ColinChamber ColinChamber added the help wanted Extra attention is needed label May 6, 2023
@git-hulk
Copy link
Member

git-hulk commented May 6, 2023

Cool, looks good to me.

Upgrade the version of dependencies: Currently, the version of our dependencies, such as k8s, is v0.19.x. I suggest that we upgrade the version in this release.

Yes, it's better to keep up with the latest release.

@tianshimoyi
Copy link
Collaborator

@jiayouxujin

  1. The reason why openkruise's sts is used is to use the reserveOrdinals function. When shrinking, if the serial number of the master is high, use this function to skip the master node and go to the slave node.

@jiayouxujin
Copy link
Collaborator Author

@jiayouxujin

  1. The reason why openkruise's sts is used is to use the reserveOrdinals function. When shrinking, if the serial number of the master is high, use this function to skip the master node and go to the slave node.

Thank you @tianshimoyi , it is helpful. I will check that again.

@ColinChamber ColinChamber added the summer-ospp-related Information, tasks, and plans related to the Summer OSPP 2023. label May 16, 2023
@jiayouxujin jiayouxujin changed the title Kvrocks Operator ' Standard' mode release plan Kvrocks Operator Standard mode release plan May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed summer-ospp-related Information, tasks, and plans related to the Summer OSPP 2023.
Projects
None yet
Development

No branches or pull requests

4 participants