Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename library to just 'rndphrase'? #4

Open
rlindsgaard opened this issue Aug 4, 2014 · 3 comments
Open

Rename library to just 'rndphrase'? #4

rlindsgaard opened this issue Aug 4, 2014 · 3 comments

Comments

@rlindsgaard
Copy link
Member

When importing a package in the firefox sdk only small letters, hyphens and underscores are allowed. This might be a problem elsewehere. Currently I fix it with https://github.com/RndPhrase/RndPhrase-Firefox/blob/master/scripts/install-packages.sh which is kind of a hack.

@Munter
Copy link
Member

Munter commented Aug 4, 2014

Well, 'rndphrase' is already the name of the original browser extension, so I wouldn't try to cause confusion by clashing the name space. Especially since this repository will look more official than Johans, organization name and all...

I'd say not being able to import libraries based on their name is a bug in Firefox

@rlindsgaard
Copy link
Member Author

You might be right. If this is only a problem in Firefox there is no reason to change it.

However, if it shows that other browsers have similar problems I'd argue that the name should be changed. IMO RndPhrase is still primarily targeted for browser plugins. In such case we could choose 'rndphrase-js' or similar in order to avoid name collision and confusion.

@rlindsgaard
Copy link
Member Author

Don't put "js" or "node" in the name. It's assumed that it's js, since you're writing a package.json file - source https://www.npmjs.org/doc/files/package.json.html

because of the namespace clash i agree that rndphrase is a bad choice. I am thinking that perhaps we can name it "rndphrase-improved".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants