Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two's complement support for the //read command #360

Open
Noname-Official opened this issue Jan 21, 2024 · 2 comments
Open

Two's complement support for the //read command #360

Noname-Official opened this issue Jan 21, 2024 · 2 comments

Comments

@Noname-Official
Copy link

You should be able to supply an argument to //read that tells it if the binary number should be interpreted as two's complement.

Can I be assigned to this issue?
Can someone please explain how the workflow with Github and Minecraft modding goes? I am new to both and would like to try something out.

@Matthias1590
Copy link
Member

Matthias1590 commented Jan 21, 2024

best approach would probably be to make the number argument type interpret binary numbers that start with some special prefix (maybe 2b instead of 0b) as 2s complement, that way it could be used anywhere

@RUGMJ
Copy link
Member

RUGMJ commented Jan 21, 2024

the above method would make this work with /base too, i wont assign you just yet as there's some changes coming up with how argument types work which may effect your pull request. Once the rewrite is done i'll assign you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants