Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More localized text #276

Open
Nitrrine opened this issue Jun 9, 2023 · 11 comments
Open

More localized text #276

Nitrrine opened this issue Jun 9, 2023 · 11 comments

Comments

@Nitrrine
Copy link
Contributor

Nitrrine commented Jun 9, 2023

I think i can try to do this

@MiranCZ
Copy link
Contributor

MiranCZ commented Jun 9, 2023

What is this supposed to add?

@Nitrrine
Copy link
Contributor Author

Nitrrine commented Jun 9, 2023

For now we have only this available keywords to localization

{
    "gamerule.doContainerDrops": "Do container drops",
    "gamerule.doContainerDrops.description": "Controls resource drops from containers",
    "gamerule.doBlockUpdatesAfterEdit": "Do block updates after edit",
    "gamerule.doBlockUpdatesAfterEdit.description": "Force update blocks after editing them in WorldEdit"
}

I'm planning to add more keywords like command.error.blockNotHaveBlockState etc.

@MiranCZ
Copy link
Contributor

MiranCZ commented Jun 9, 2023

Yeah, I dont think thats planned for now, not sure tho

@Nitrrine
Copy link
Contributor Author

Nitrrine commented Jun 9, 2023

Okay, in this case, should I close this issue or leave it?

@MiranCZ
Copy link
Contributor

MiranCZ commented Jun 9, 2023

Wait, what matthias says, I could be wrong

@Nitrrine
Copy link
Contributor Author

Nitrrine commented Jun 9, 2023

Yeah, let's wait until he answers

@Matthias1590
Copy link
Member

If this also changes the feedback system to translation keys then i dont mind this being implemented

@Nitrrine
Copy link
Contributor Author

Nitrrine commented Jun 10, 2023

You mean this?
Because i want to implement it like this, or Feedback also saves message to telemetry data?

Feedback.invalidUsage("command.copystate.feedback.notHaveBlockstate")

@Matthias1590
Copy link
Member

yeah

@Matthias1590
Copy link
Member

the translation keys should probably be in some utils class but yeah

@Nitrrine
Copy link
Contributor Author

Hm, I'll think a little about how it will be possible to implement this in the best way, and if I come up with something, I'll reply here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants