Rename error to make revive linter happy

Replacing the "github.com/pkg/errors" with "errors" reveal a lint issue
with the revive linter:

    InitialWaitTimeForDRPCPlacementRule should have name of the form ErrFoo (revive)

While fixing, remove pointless wrapping. errors.Is() is documented to
match any error in err's tree including err itself.

Signed-off-by: Nir Soffer <[email protected]>

internal/controller/drplacementcontrol_controller.go

@@ -60,7 +60,7 @@ const (
 	DoNotDeletePVCAnnotationVal = "true"
 )
 
-var InitialWaitTimeForDRPCPlacementRule = errors.New("Waiting for DRPC Placement to produces placement decision")
+var ErrInitialWaitTimeForDRPCPlacementRule = errors.New("waiting for DRPC Placement to produces placement decision")
 
 // ProgressCallback of function type
 type ProgressCallback func(string, string)
@@ -222,17 +222,17 @@ func (r *DRPlacementControlReconciler) Reconcile(ctx context.Context, req ctrl.R
 	}
 
 	d, err := r.createDRPCInstance(ctx, drPolicy, drpc, placementObj, ramenConfig, logger)
-	if err != nil && !errors.Is(err, InitialWaitTimeForDRPCPlacementRule) {
+	if err != nil && !errors.Is(err, ErrInitialWaitTimeForDRPCPlacementRule) {
 		err2 := r.updateDRPCStatus(ctx, drpc, placementObj, logger)
 
 		return ctrl.Result{}, fmt.Errorf("failed to create DRPC instance (%w) and (%v)", err, err2)
 	}
 
-	if errors.Is(err, InitialWaitTimeForDRPCPlacementRule) {
+	if errors.Is(err, ErrInitialWaitTimeForDRPCPlacementRule) {
 		const initialWaitTime = 5
 
 		r.recordFailure(ctx, drpc, placementObj, "Waiting",
-			fmt.Sprintf("%v - wait time: %v", InitialWaitTimeForDRPCPlacementRule, initialWaitTime), logger)
+			fmt.Sprintf("%v - wait time: %v", ErrInitialWaitTimeForDRPCPlacementRule, initialWaitTime), logger)
 
 		return ctrl.Result{RequeueAfter: time.Second * initialWaitTime}, nil
 	}
@@ -791,7 +791,7 @@ func (r *DRPlacementControlReconciler) getDRPCPlacementRule(ctx context.Context,
 
 		// Make sure that we give time to the DRPC PlacementRule to run and produces decisions
 		if drpcPlRule != nil && len(drpcPlRule.Status.Decisions) == 0 {
-			return fmt.Errorf("%w", InitialWaitTimeForDRPCPlacementRule)
+			return ErrInitialWaitTimeForDRPCPlacementRule
 		}
 	} else {
 		log.Info("Preferred cluster is configured. Dynamic selection is disabled",