Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed file path on source code #1

Open
jremes-foss opened this issue Apr 12, 2016 · 0 comments
Open

Fixed file path on source code #1

jremes-foss opened this issue Apr 12, 2016 · 0 comments

Comments

@jremes-foss
Copy link

Hello.

Looks like you have a little design problem in your source code. Namely on the line 48, variable filePath is fixed.

In general, this is a bad practice. If someone else in the department wants to run this script, the script aborts because the file is not found.

In order to fix this I'd suggest the following: Script asks specifically the folder path before it starts to execute.

Thanks.

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jremes-foss