Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change public offer read model to async #255

Open
lukaszreszke opened this issue Jan 23, 2023 · 2 comments
Open

Change public offer read model to async #255

lukaszreszke opened this issue Jan 23, 2023 · 2 comments

Comments

@lukaszreszke
Copy link
Collaborator

Public offer use SingleTableReadModel class to build read model. We would like read models to work in an asynchronous way.

Keep in mind that changing read model from sync to async will affect UI/UX experience. One could deal with that using turbo, but there are other ways as well that could be used.
@lukaszreszke lukaszreszke mentioned this issue Jan 23, 2023
Closed
@bryszard
Copy link
Collaborator

bryszard commented Mar 6, 2023

@lukaszreszke I'm thinking about taking this one, but I'm not sure what do you want to achieve when it comes to the UI/UX.

From my perspective, the eventual consistency in this scenario is an acceptable behaviour. The public does not know that admin is changing the offer, so a delay here does not matter. On the admin side, if the update is not yet there, he can reload the page.

What is your point of view?

@bryszard bryszard self-assigned this Mar 6, 2023
@bryszard
Copy link
Collaborator

bryszard commented Mar 8, 2023

Hmmm, it looks to me that this is already done :p. Should this issue be closed?

@bryszard bryszard removed their assignment Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryszard @lukaszreszke