Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSG bugs #295

Open
LogicalError opened this issue Oct 12, 2020 · 3 comments
Open

CSG bugs #295

LogicalError opened this issue Oct 12, 2020 · 3 comments
Assignees
@LogicalError
Labels
bug Something isn't working
Milestone
Sash Mortise

Comments

@LogicalError
Copy link
Member

There are several CSG bugs, most of them seem to have to do with merging vertices
@LogicalError LogicalError added the bug Something isn't working label Oct 12, 2020
@LogicalError LogicalError added this to the Sash Mortise milestone Oct 12, 2020
@LogicalError LogicalError self-assigned this Oct 12, 2020
@LogicalError
Copy link
Member Author

Some bugs have been fixed in #297

@LogicalError
Copy link
Member Author

Seems the last bug is vertices being merged when they shouldn't. This is because vertices are merged based on distance, when it should be based on comparing intersecting plane triplets on multiple vertices.

Right now this distance merging fails on sharply angled planes where vertices that are very close to each other get merged and create polygons which causes degenerate edges on polygons

A B C
---->--->*
| <---
/B C

A,B,C are vertices, and thee edge BC is followed by CB
This causes problems further on in the pipeline.

@LogicalError
Copy link
Member Author

Apparently github kills ascii art. awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LogicalError LogicalError

Labels
bug Something isn't working
Projects
None yet
Milestone
Sash Mortise
Development

No branches or pull requests
1 participant
@LogicalError