Dependencies of qubes-desktop-linux-manager not stated.

[unman]

How to file a helpful issue

Qubes OS release

4.2

Brief summary

From XMachina via Forum:
"Currently, the icons for the domains widgets is provided by the package xfce4-settings. I have tested this by installing and uninstalling this package and its dependencies recursively, and it is definitely this package. (Side note: I'd wager this is why these icons aren't on i3 [https://github.com//issues/7754].) The icons need to be provided in a different package and included or required by qubes-desktop-linux-manager.
The same applies for the package python3-gobject providing the individual progressbar/x/check for the Qubes Updater GUI."

Steps to reproduce

Install another DE - remove the xfce4-settings package - note that domains widget icons are no longer available.
Remove package python3-gobject - note that progress bar is not available in Updater GUI

Expected behavior

Necessary packages will be stated as dependencies

Actual behavior

Necessary packages are not stated as dependencies of qubes-desktop-linux-manager, and can be removed at will.
Possible related to #7754 for i3 WM

[FaithKovi]

Hello @marmarta I want to work on this.

[FaithKovi]

hello @andrewdavidwong , I am new to the project and would need some guidance with more information on how to make this first contribution.

[ben-grande]

@FaithKovi

1. Read the code section from the docs
2. Identify the RPM spec of qubes-desktop-linux-manager in the repository
3. Follow the first post on steps to reproduce the issue and add the missing dependencies to the RPM spec
4. Create a branch, commit linking this issue in the body of the commit, push to your repo, open PR against the qubes repo that holds the qubes-desktop-linux-manager package

[FaithKovi]

Thank you @ben-grande

[fepitre]

A quick feedback related to issue #7754 I have both DE XFCE and i3 but even without uninstalling any dependencies, I still don't have icons in the widgets.