Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation that contains 0 only should not crash the converter #471

Open
fedorov opened this issue Jun 27, 2023 · 0 comments
Open

Segmentation that contains 0 only should not crash the converter #471

fedorov opened this issue Jun 27, 2023 · 0 comments

Comments

@fedorov
Copy link
Member

fedorov commented Jun 27, 2023

If input JSON contains only label id "0", there should be an error. If image does not contain any labels that are passed in JSON there should be an error.

I do not want to force users to always define semantics of 0. We need to have a way to communicate that some slices do not contain anything of value (otherwise, how would we decide which slices to skip during conversion?). Right now, 0 in the input image effectively communicates that those slices do not have anything. If background needs to be encoded, it will have to be non-zero label.

If there is a need to explicitly encode certain segment as "Background", it would have to have a non-zero value in the image. Probably, the right code for that would be "Background" from this table: https://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_CID_7165.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant