Skip to content
This repository has been archived by the owner on Apr 7, 2020. It is now read-only.

Transactionalization of AclManager database calls #2

Open
Problematic opened this issue May 17, 2011 · 0 comments
Open

Transactionalization of AclManager database calls #2

Problematic opened this issue May 17, 2011 · 0 comments

Comments

@Problematic
Copy link
Owner

Right now, there are potentially a LOT of database calls being made by the ACL Manager. I implemented some rudimentary transactionalization in processPermissions(), but it could be a lot better. Something like this, perhaps:

$aclManager->beginTransaction('identifier');
// ... add permission contexts
$aclManager->loadAcl($entity1)->processPermissions();
$aclManager->loadAcl($entity2)->processPermissions();
$aclManager->commit();

Right now, the DB is being hit at least twice, once for each call to processPermissions(). With a transaction manager, it could be condensed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant