Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe SIMD in relativistic Riemann solvers #521

Open
felker opened this issue Jun 9, 2023 · 2 comments
Open

Fix unsafe SIMD in relativistic Riemann solvers #521

felker opened this issue Jun 9, 2023 · 2 comments

Comments

@felker
Copy link
Contributor

felker commented Jun 9, 2023

Following #518 and specifically d59c678, OpenMP-based explicit SIMD was disabled for frame transformation-based HLLE (Hydro and MHD) and HLLC (Hydro) relativistic Riemann solvers. This likely degrades performance; need to diagnose the root cause of the regression test failures:

    sr.hydro_convergence: failed; time elapsed: 36.8 s
    sr.hydro_shocks_hllc: failed; time elapsed: 38.1 s
    sr.hydro_shocks_hlle: failed; time elapsed: 36 s
...
    sr.mhd_shocks_hlle: failed; time elapsed: 41.1 s

And need to double check any gaps in GR/SR Riemann solver test coverage for any further correctness issues that may be lurking in the code.

@c-white
Copy link
Contributor

c-white commented Jun 9, 2023

If vectorization is really causing these failures, even when simdlen is eliminated, I worry about the other simd calls in the relativistic Riemann solvers:

grep '\<simd\>' src/hydro/rsolvers/**/*_rel*

They are all doing pretty much the same thing. The workhorse in most production code is hlle_mhd_rel_no_transform.cpp. At least I guess that hasn't broken, yet.

@felker
Copy link
Contributor Author

felker commented Jun 13, 2023

yeah, I don't really understand what is wrong. Need to review what (if anything) we learned from #349 and #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants