You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following #518 and specifically d59c678, OpenMP-based explicit SIMD was disabled for frame transformation-based HLLE (Hydro and MHD) and HLLC (Hydro) relativistic Riemann solvers. This likely degrades performance; need to diagnose the root cause of the regression test failures:
sr.hydro_convergence: failed; time elapsed: 36.8 s
sr.hydro_shocks_hllc: failed; time elapsed: 38.1 s
sr.hydro_shocks_hlle: failed; time elapsed: 36 s
...
sr.mhd_shocks_hlle: failed; time elapsed: 41.1 s
And need to double check any gaps in GR/SR Riemann solver test coverage for any further correctness issues that may be lurking in the code.
The text was updated successfully, but these errors were encountered:
If vectorization is really causing these failures, even when simdlen is eliminated, I worry about the other simd calls in the relativistic Riemann solvers:
grep '\<simd\>' src/hydro/rsolvers/**/*_rel*
They are all doing pretty much the same thing. The workhorse in most production code is hlle_mhd_rel_no_transform.cpp. At least I guess that hasn't broken, yet.
Following #518 and specifically d59c678, OpenMP-based explicit SIMD was disabled for frame transformation-based HLLE (Hydro and MHD) and HLLC (Hydro) relativistic Riemann solvers. This likely degrades performance; need to diagnose the root cause of the regression test failures:
And need to double check any gaps in GR/SR Riemann solver test coverage for any further correctness issues that may be lurking in the code.
The text was updated successfully, but these errors were encountered: