Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment names not updating through the UI #16085

Closed
mthatt opened this issue Nov 21, 2024 · 2 comments
Closed

Deployment names not updating through the UI #16085

mthatt opened this issue Nov 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mthatt
Copy link
Contributor

mthatt commented Nov 21, 2024

Bug summary

Updating a deployment name through the UI doesn't seem to work. I see a deployment.updated event in the audit log and event feed, but the deployment name doesn't change.

Version info

Version:             3.0.3
API version:         0.8.4
Python version:      3.11.8
Git commit:          d9c51bc3
Built:               Fri, Sep 20, 2024 8:52 AM
OS/Arch:             darwin/arm64
Profile:             cloud
Server type:         cloud
Pydantic version:    2.8.2
Integrations:
  prefect-ray:       0.4.0rc2
  prefect-aws:       0.5.0rc2
  prefect-github:    0.3.0rc2
  prefect-docker:    0.6.0rc3
  prefect-gcp:       0.6.0rc2
  prefect-email:     0.4.0rc1
  prefect-snowflake: 0.28.0rc1
  prefect-shell:     0.3.0rc1
  prefect-dbt:       0.6.0rc2
  prefect-azure:     0.4.0rc2
  prefect-databricks: 0.3.0rc2
  prefect-kubernetes: 0.4.0rc3
  prefect-bitbucket: 0.3.0rc1
  prefect-dask:      0.3.0rc2
  prefect-sqlalchemy: 0.5.0rc2
  prefect-gitlab:    0.3.0rc1
  prefect-slack:     0.3.0rc2

Additional context

Note that we can see the 'Last Updated' field change.

Before:
Screenshot 2024-11-21 at 1 49 24 PM

The desired change:
Screenshot 2024-11-21 at 1 49 54 PM

After:
Screenshot 2024-11-21 at 1 50 07 PM

@mthatt mthatt added the bug Something isn't working label Nov 21, 2024
@EmilRex
Copy link
Contributor

EmilRex commented Nov 22, 2024

On a related note, I thought this was possible to update via the API but PATCH'ing a deployment with name returns a 422 Unprocessable Entity.

@zzstoatzz
Copy link
Collaborator

to surface discussion, patching the deployment name is not currently possible, as it would need to be a field on DeploymentUpdate

https://github.com/prefecthq/prefect/blob/main/src/prefect/client/schemas/actions.py#L204-L273

@mthatt the recommendation would be to recreate the deployment with a new name, we should probably remove the apparent option to update the name in the UI to reduce confusion

@aaazzam aaazzam closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants