Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying timeout for resources #571

Open
SteveL-MSFT opened this issue Oct 9, 2024 · 2 comments
Open

Support specifying timeout for resources #571

SteveL-MSFT opened this issue Oct 9, 2024 · 2 comments
Labels
Issue-Enhancement The issue is a feature or idea Needs Triage
Milestone

Comments

@SteveL-MSFT
Copy link
Member

Summary of the new feature / enhancement

In the Microsoft.DSC section of metadata, allow configuration to specify a timeout. It may also make sense to just have a default timeout so configuration isn't blocked indefinitely.

Proposed technical implementation details (optional)

No response

@SteveL-MSFT SteveL-MSFT added Issue-Enhancement The issue is a feature or idea Needs Triage labels Oct 9, 2024
@SteveL-MSFT SteveL-MSFT added this to the Post-3.0 milestone Oct 9, 2024
@michaeltlombardi
Copy link
Collaborator

A few related questions:

  • Would it be useful to have a --timeout option on the dsc resource * commands?
  • Should we consider an API surface for adapters to handle timeouts for their adapted resources?

@SteveL-MSFT
Copy link
Member Author

It probably makes sense to have --timeout for both resource invocation and config invocation at the command-line level in addition to allowing config authors to specify timeouts.

For adapters, I think they should just follow the same contract which is metadata at the resource level should be respected. However, we may need adapters to publish what capabilities they support and perhaps even reject explicitly any metadata it doesn't understand so users don't set something that doesn't apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement The issue is a feature or idea Needs Triage
Projects
None yet
Development

No branches or pull requests

2 participants