Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GuiChat ASM surrounding too many instructions with if statement #64

Closed
MicrocontrollersDev opened this issue Jul 22, 2024 · 1 comment

Comments

@MicrocontrollersDev
Copy link

The code injected in the GuiChat.drawScreen method is surrounding all the code from the start of the method up to the drawRect call with an if statement.

https://github.com/Sk1erLLC/Patcher/blob/4ce6e196e5ad1339f8a0ab96eb5680c2f6464583/src/main/java/club/sk1er/patcher/asm/render/screen/GuiChatTransformer.java#L67

If another ASM mod injected code at HEAD, that code will be wraped too with the if statement.

I suggest deleting that ASM and instead use a mixin using the @WrapWithCondition (OSS mixin relauncher when) targeting the drawRect call

Copied from Sk1erLLC#187
@Wyvest
Copy link
Member

Wyvest commented Jul 27, 2024

tracking via discord

@Wyvest Wyvest closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants