Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise use of fails in tests #85

Closed
srid opened this issue Jan 10, 2022 · 1 comment
Closed

Revise use of fails in tests #85

srid opened this issue Jan 10, 2022 · 1 comment
Labels
testing

Comments

@srid
Copy link
Member

srid commented Jan 10, 2022

This doesn't seem right. Per the semantics of fails it expects either user error (EvaluationError) or engine error/bug (EvaluationException). Even EvaluationError is not precise:

data EvaluationError user internal
    = InternalEvaluationError internal
      -- ^ Indicates bugs.
    | UserEvaluationError user
      -- ^ Indicates user errors.

What we want is to test that the result is exactly a perror (and not general evaluation error/exception).

Originally posted by @srid in #84 (comment)
@srid srid mentioned this issue Jan 10, 2022
Merged
@srid srid added the testing label Jan 28, 2022
@srid
Copy link
Member Author

srid commented Feb 14, 2022

We need IntersectMBO/plutus#4270

srid added a commit that referenced this issue Feb 14, 2022
@srid
post-eval uplc golden: treat failures as perror
786bd38 
Resolves #85
@L-as L-as closed this as completed in 3c07d71 Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srid