Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

big-integer removal from the dependency tree #1552

Open
klntsky opened this issue Oct 13, 2023 · 3 comments
Open

big-integer removal from the dependency tree #1552

klntsky opened this issue Oct 13, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@klntsky
Copy link
Member

klntsky commented Oct 13, 2023

Initially, we decided to use json-bigint fork adapted for our needs, because we knew that we depend on bignumber.js anyway. Since bigints package is deprecated, we are no more required to depend on bignumber.js, and so we should drop bignumber.js from all dependencies to avoid tech debt.

The ask:

  1. Replace all uses of bignumber.js in the json-bigint package with native JS BigInt. Big integer type is only used for parsing/serializing there, it must be straightforward
  2. Make sure the tests pass
  3. Upload a new version to NPM or ask me to - https://www.npmjs.com/package/@mlabs-haskell/json-bigint
  4. Update the version of json-bigint in aeson-bigint
  5. Update the version of aeson-bigint in CTL
@klntsky
Copy link
Member Author

klntsky commented Oct 13, 2023

This should be on top of #1521

@kozross kozross self-assigned this Oct 15, 2023
@kozross kozross moved this from Todo to In Progress in cardano-transaction-lib Oct 15, 2023
@kozross kozross added the enhancement New feature or request label Oct 15, 2023
@klntsky klntsky changed the title biginteger.js removal from the dependency tree big-integer removal from the dependency tree Nov 10, 2023
@klntsky
Copy link
Member Author

klntsky commented Nov 10, 2023

@klntsky
Copy link
Member Author

klntsky commented Nov 10, 2023

It is also fairly easy to remove BigNumber.js and bignumber PS package dependency (used in Internal/Service/Blockfrost.purs)

@klntsky klntsky assigned klntsky and unassigned kozross Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants