Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Replace IR with bytecode #1311

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

erick-xanadu
Copy link
Contributor

@erick-xanadu erick-xanadu commented Nov 18, 2024

Context: Writing uncompressed human readable IR to disk takes longer to parse and dump than using compressed MLIR bytecode. Benchmark results discussed offline.

Description of the Change: Use compressed MLIR bytecode when sending a module to the compiler.

Benefits: Less compilation time (depending on how big the IR produced is)

Possible Drawbacks:

Related GitHub Issues:

[sc-78851]

@erick-xanadu erick-xanadu marked this pull request as ready for review November 18, 2024 14:59
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.44%. Comparing base (4925d37) to head (bdaed9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1311   +/-   ##
=======================================
  Coverage   81.43%   81.44%           
=======================================
  Files          74       74           
  Lines        8172     8174    +2     
  Branches      861      861           
=======================================
+ Hits         6655     6657    +2     
  Misses       1460     1460           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Erick! Would also to see whether this makes a difference in compile time.

Btw does this affect the 0_* stage in intermediate files or not really?

frontend/catalyst/compiler.py Show resolved Hide resolved
frontend/catalyst/compiler.py Outdated Show resolved Hide resolved
@erick-xanadu
Copy link
Contributor Author

Btw does this affect the 0_* stage in intermediate files or not really?

No.

@erick-xanadu erick-xanadu changed the title Replace IR with bytecode [Frontend] Replace IR with bytecode Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants