Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-Fix SignUp #2477

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Conversation

ArinNigam
Copy link

What kind of change does this PR introduce?
Bug-Fix

Issue Number:
Fixes #2454

Did you add tests for your changes?
Yes, I have made changed in the unit tests to make sure workflow doesn't fail.

Snapshots/Videos:
SignUp is working fine now

SignUpWorking.mp4

If relevant, did you update the documentation?
No

Summary
SignUp was failing for the app continuously which was acting as an hindrance to the other issues after the signup process. It solves the problem of SignUp and now the user can log in after signing it without any problem.

Does this PR introduce a breaking change?
Yes

Have you read the contributing guide?
Yes

This was causing error since at client side we were not providing the id of organization while registering.
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (0087e3a) to head (8dc7e50).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2477   +/-   ##
========================================
  Coverage    96.42%   96.42%           
========================================
  Files          152      152           
  Lines         7587     7588    +1     
========================================
+ Hits          7316     7317    +1     
  Misses         271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes merged commit 05b89f4 into PalisadoesFoundation:develop Apr 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: SignUp (Mobile)
2 participants