-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin - Select organization on registration #1440
Comments
Would like to contribute! Pls assign. |
@palisadoes Can i work on the Talawa-admin part for this, please? |
@palisadoes can i work on this? |
@Sejal1411 Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too. |
I would like to work on the talawa-admin part of this issue please assign it to me |
@Cioppolo14 I have unassigned myself from one of the issues. Can i get assigned to this issue? |
@Sejal1411 i got this issue assigned already , maybe you can work on the api part for the same 👀 |
@Sejal1411 If this issue wasn't already assigned, at this point I could assign you. In the future, if you are first to comment requesting an issue and you really want that issue, make sure you have less than 2 total issues for when I go to do assignments. Thank you for understanding. |
|
|
@palisadoes I had been working on another issue and have been ignorant about this one. I will be immediately on this sir 👍 |
@palisadoes Sir , in the select organization page, should the user have options to join multiple organizations or only one to start with. Can it be something like this where instead of topics we have organizations ? |
One |
@palisadoes Sir, Is something like this fine? |
@palisadoes Sir, maybe we can add a dropdown field to select from all available organisations? Something like this? https://www.figma.com/file/6xACotBTh0GU3POVqZbMX0/Untitled?type=design&node-id=0%3A1&mode=design&t=4tJRjxZscGMivMpw-1 |
OK |
When do you think you'll be able to raise a PR for this? |
@palisadoes Sir , I have completed the frontend part , I am working on implementing the logic. I will make the PR ASAP or latest by this weekend. |
@palisadoes Sir, Is this signUp mutation behavior expected, because in the above merged blocking PR , the expected output was somewhat different. How should I proceed about this? Screencast.from.2024-02-08.22-29-31.webm |
If that case comment on the PR's issue with what you'd expect and let's reopen it to have the expected behavior |
However, this PR was created to rectify a previously identified bug. |
The API PR is now complete. You can proceed. This is could be showstopper issue for new registrations. Do you have time to complete this by the weekend? |
@palisadoes That is good news sir. Unfortunately I have exams till the end of the week. But , most of the other work is done so, I can work modestly this week, get done with most work on weekend plus one two more days and make the PR ASAP. |
Good luck with your exams. That comes first. Thanks for the update. |
Be aware of this: |
@palisadoes Yes sir. I have already fixed it locally . This issue will rise for not only the super admin but also for every user trying to register. I will push it up with all the changes. |
@palisadoes Sir , there have been a lot of changes to the api repo which has rendered a large part of the admin side inconsistent. Major problem, The usertype is removed from the login mutation so now we cannot directly see if the user is a ADMIN, SUPERADMIN, or a USER. How do i proceed further with this? |
The |
Screencast.from.14-04-24.12.55.33.PM.IST.webm@palisadoes Sir , this is ready. Does this look fine? |
Yes. Finally! How does it work with a fresh installation where the |
@palisadoes Sir , here is how it works for Screencast.from.15-04-24.07.16.02.PM.IST.webm |
Thanks. Please submit a PR |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Is your feature request related to a problem? Please describe.
We are working on migrating the approval of requests to join organizations to a new Admin screen as outlined in this issue:
Prior to this the process was:
There were disadvantages to this approach:
Describe the solution you'd like
TALAWA API
USER
s andNON_USER
s will need to select an organization when registering so that the request can be directed to the correct organization's Admin screens.TALAWA MOBILE
Talawa API
registration mutation.TALAWA ADMIN
Talawa API
registration mutation.OTHER
Describe alternatives you've considered
Approach to be followed (optional)
Additional context
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: