Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MC 1.20.6] [Forgix 1.2.9] neoforge.mods.toml not updated with neoforge- prefix for mixin configuration #29

Open
jason13official opened this issue May 5, 2024 · 2 comments

Comments

@jason13official
Copy link

jason13official commented May 5, 2024

I'm using the MultiLoader-Template project (google-able), and attempting to merge common, fabric, and neoforge. The mixin files are prefixed with their loader after merging, such as fabric-examplemod.fabric.mixins.json, and neoforge-examplemod.neoforge.mixins.json. However when opening the merged jar with a tool such as WinRAR, the neoforge.mods.toml file has not been updated, causing a crash without a useful error log.

EDIT: I have the mixin file configured in forgix {} within build.gradle
EDIT 2: I've made the repository public if it will help at all https://github.com/Cursee-Development/Danger-Close

@jason13official jason13official changed the title [1.20.6] neoforge.mods.toml not updated with neoforge- prefix for mixin configuration [MC 1.20.6] [Forgix 1.2.9] neoforge.mods.toml not updated with neoforge- prefix for mixin configuration May 5, 2024
@hypherionmc
Copy link
Collaborator

hypherionmc commented May 5, 2024

I am familiar with the template you mentioned.

Keep in mind that neoforge support is still experimental, and hasn't fully been tested. I will run some tests later today to see what can be done to fix it.

It also doesn't help that neoforge has two different ways of specifying mixins.... Older neoforge used the same MixinConfigs in the manifest like forge did, and newer neoforge supports both mods.toml and MixinConfigs in the manifest, making it harder to support, but not impossible

Edit: I see you are targeting 1.20.6, which makes it a bit easier to fix 😄

@jason13official
Copy link
Author

Thank you for a response 🙏 For now I'm just manually updating the neoforge.mods.toml with WinRAR 💀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants