Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Missing one step in SITL unit tests documentation #943

Open
roangel opened this issue Feb 5, 2020 · 5 comments
Open

Missing one step in SITL unit tests documentation #943

roangel opened this issue Feb 5, 2020 · 5 comments

Comments

@roangel
Copy link

roangel commented Feb 5, 2020

I think there is a missing step here:
https://github.com/PX4/Devguide/blob/6194b65f72615ffbcb4c8ed07a6b2a07a9a9362d/en/test_and_ci/unit_tests.md

In the section Writing a SITL Unit Test, we also need to add the test to platforms/posix/cmake/sitl_tests.cmake, and it's not mentioned anywhere.

@hamishwillee
Copy link
Collaborator

@jkflying Can you please comment on this ^^^.

@roangel FYI only, you can create an issue report or PRs from the top of each docs page. Slightly simpler for you because it populates the link to the affected page.
image

@roangel
Copy link
Author

roangel commented Feb 5, 2020

@jkflying Can you please comment on this ^^^.

@roangel FYI only, you can create an issue report or PRs from the top of each docs page. Slightly simpler for you because it populates the link to the affected page.
image

Aha, ok, thanks!

@jkflying
Copy link
Contributor

jkflying commented Feb 6, 2020

I've actually never worked with these SITL unit tests. There is the instruction already to add your test to the systemcmds/tests/CMakeLists.txt, which I think should be sufficient, but I'm not 100% sure.

@hamishwillee
Copy link
Collaborator

Thanks @jkflying . @julianoes Are you any "more sure"?

@julianoes
Copy link
Contributor

@MaEtUgR might know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants