Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an optional Prettier pre-commit hook. #126

Open
HarshKapadia2 opened this issue Dec 23, 2022 · 2 comments
Open

Add an optional Prettier pre-commit hook. #126

HarshKapadia2 opened this issue Dec 23, 2022 · 2 comments
Labels
CI/CD Issues related to CI/CD documentation Improvements or additions to documentation

Comments

@HarshKapadia2
Copy link
Member

If possible, we can add code for a generalised pre-commit hook in CONTRIBUTING.md to run Prettier before committing locally.

Credits: @KartikSoneji
@HarshKapadia2 HarshKapadia2 added documentation Improvements or additions to documentation CI/CD Issues related to CI/CD labels Dec 23, 2022
@KartikSoneji KartikSoneji changed the title Add a Prettier pre-commit hook. Add an optional Prettier pre-commit hook. Dec 23, 2022
@KartikSoneji KartikSoneji mentioned this issue Dec 23, 2022
Open
@KartikSoneji
Copy link
Member

I'll try to add it as an npm script, so you can run npm run enable-lint or npm run disable-lint and it will enable or disable the pre-commit hooks.

@KartikSoneji KartikSoneji mentioned this issue Dec 23, 2022
Open
@tusharnankani
Copy link
Member

I'll try to add it as an npm script, so you can run npm run enable-lint or npm run disable-lint and it will enable or disable the pre-commit hooks.

Yes, makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/CD Issues related to CI/CD documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KartikSoneji @HarshKapadia2 @tusharnankani